Freestyle Effects for @tagless #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
Jan 12, 2018
fedefernandez
approved these changes
Jan 12, 2018
peterneyens
reviewed
Jan 12, 2018
| trait Implicits { | ||
| implicit def freeStyleEitherMHandler[M[_]]( | ||
| implicit ME: MonadError[M, E]): EitherM.Handler[M] = new EitherM.Handler[M] { | ||
| def either[A](fa: Either[E, A]): M[A] = fa.fold(ME.raiseError[A], ME.pure[A]) |
There was a problem hiding this comment.
This can be ME.fromEither(fa)
|
|
||
| implicit def freeStyleErrorMHandler[M[_]]( | ||
| implicit ME: MonadError[M, Throwable]): ErrorM.Handler[M] = new ErrorM.Handler[M] { | ||
| def either[A](fa: Either[Throwable, A]): M[A] = fa.fold(ME.raiseError[A], ME.pure[A]) |
There was a problem hiding this comment.
This could also be ME.fromEither(fa).
peterneyens
reviewed
Jan 12, 2018
|
|
||
| final class FutureOps[A](f: Future[A]) { | ||
|
|
||
| def to[F[_]](implicit AC: AsyncContext[F], E: ExecutionContext): F[A] = future2AsyncM[F, A](f) |
There was a problem hiding this comment.
Personally I think I would call this unsafeTo, but the AsyncM type class has no real "suspension" guarantees.
We could implement it more safely for Eval[Future[A]] or a method which takes => Future[A].
We just have to remember that when we want to end up in something like monix Task or cats.effect.IO, this to method is probably not the best route.
There was a problem hiding this comment.
Sounds good, I've just deprecated it in 9acae08
There was a problem hiding this comment.
Sounds good. Created #509
juanpedromoreno
force-pushed
the
jp-freestyle-effects-tagless
branch
from
68e02b6
to
9acae08
Compare
peterneyens
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support for freestyle-effects for @tagless final encoding.
From now on,
asyncCatsEffectandasyncGuavahave been moved tofreestyle.async(both async integrations are not really tied tofree.Releases a new minor version due to the breaking changes in this PR: 0.6.0.