-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging → Prod #868
Staging → Prod #868
Conversation
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.11. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) from 14.2.5 to 14.2.14. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v14.2.14/packages/eslint-config-next) --- updated-dependencies: - dependency-name: eslint-config-next dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [next-intl](https://github.com/amannn/next-intl) from 3.17.2 to 3.20.0. - [Release notes](https://github.com/amannn/next-intl/releases) - [Changelog](https://github.com/amannn/next-intl/blob/main/CHANGELOG.md) - [Commits](amannn/next-intl@v3.17.2...v3.20.0) --- updated-dependencies: - dependency-name: next-intl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…next-intl-3.20.0 build(deps): bump next-intl from 3.17.2 to 3.20.0
…eslint-config-next-14.2.14 build(deps-dev): bump eslint-config-next from 14.2.5 to 14.2.14
…types/react-18.3.11 build(deps-dev): bump @types/react from 18.3.3 to 18.3.11
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.46.1 to 1.47.2. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.46.1...v1.47.2) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…playwright/test-1.47.2 build(deps-dev): bump @playwright/test from 1.46.1 to 1.47.2
Bumps [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) from 14.2.14 to 14.2.15. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v14.2.15/packages/eslint-config-next) --- updated-dependencies: - dependency-name: eslint-config-next dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.4 to 5.6.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.4...v5.6.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [next](https://github.com/vercel/next.js) from 14.2.14 to 14.2.15. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.14...v14.2.15) --- updated-dependencies: - dependency-name: next dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…next-14.2.15 build(deps): bump next from 14.2.14 to 14.2.15
…typescript-5.6.3 build(deps): bump typescript from 5.5.4 to 5.6.3
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.47.2 to 1.48.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.47.2...v1.48.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…playwright/test-1.48.0 build(deps-dev): bump @playwright/test from 1.47.2 to 1.48.0
…eslint-config-next-14.2.15 build(deps-dev): bump eslint-config-next from 14.2.14 to 14.2.15
feat: Change Package manager to pnpm
fix: Remove package-lock.json
Bumps [next-intl](https://github.com/amannn/next-intl) from 3.20.0 to 3.21.1. - [Release notes](https://github.com/amannn/next-intl/releases) - [Changelog](https://github.com/amannn/next-intl/blob/main/CHANGELOG.md) - [Commits](amannn/next-intl@v3.20.0...v3.21.1) --- updated-dependencies: - dependency-name: next-intl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 2 to 4. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v2...v4) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…s/pnpm/action-setup-4 build(deps): bump pnpm/action-setup from 2 to 4
…next-intl-3.21.1 build(deps): bump next-intl from 3.20.0 to 3.21.1
* feat: Initialize API v1 for Ingredients * feat(i18n): Added translations for tooltip * feat(SCSS): Upgraded to newer SCSS version
# Conflicts: # .github/workflows/build.yml # .gitignore # package.json # playwright.config.ts # pnpm-lock.yaml # src/components/IngredientsCheck/IngredientsForm.tsx # src/components/IngredientsCheck/IngredientsList.tsx # src/components/IngredientsCheck/ResultsDisplay.tsx # src/components/IngredientsCheck/models/IngredientResult.ts # src/components/IngredientsCheck/utils/actions.test.ts # src/components/IngredientsCheck/utils/actions.ts # src/styles/_globals/_mixins.scss # src/styles/_modules/_modals.scss # src/tests/usability.spec.ts
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 2 to 4. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v2.0.0...v4) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.48.0 to 1.48.2. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.48.0...v1.48.2) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…s/pnpm/action-setup-4 build(deps): bump pnpm/action-setup from 2 to 4
…playwright/test-1.48.2 build(deps-dev): bump @playwright/test from 1.48.0 to 1.48.2
Bumps [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-estree) from 8.11.0 to 8.14.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-estree/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.14.0/packages/typescript-estree) --- updated-dependencies: - dependency-name: "@typescript-eslint/typescript-estree" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.80.4 to 1.81.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.4...1.81.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…sass-1.81.0 build(deps): bump sass from 1.80.4 to 1.81.0
…typescript-eslint/typescript-estree-8.14.0 build(deps-dev): bump @typescript-eslint/typescript-estree from 8.11.0 to 8.14.0
Run & review this pull request in StackBlitz Codeflow. |
Reviewer's Guide by SourceryThis pull request includes several significant changes focused on improving the application's functionality, styling, and development infrastructure. The main changes include upgrading dependencies, refactoring SCSS modules, enhancing the ingredients check feature with new UI components, and improving the development workflow. Sequence diagram for checkIngredients functionsequenceDiagram
participant User
participant IngredientsForm
participant Veganify
User->>IngredientsForm: Submit ingredients
IngredientsForm->>Veganify: checkIngredientsListV1(ingredients, stagingFlag)
Veganify-->>IngredientsForm: Return ingredient data
IngredientsForm-->>User: Display results
Updated class diagram for IngredientsCheck componentsclassDiagram
class IngredientsList {
+IngredientListProps
+tooltipMessages
+shouldShowTooltip
+tooltipBaseClass
+tooltipMessage
}
class ResultDisplay {
+ResultDisplayProps
}
class TooltipClient {
+TooltipProps
+isVisible
}
class IngredientResult {
+vegan: boolean | null
+surelyVegan: string[]
+notVegan: string[]
+maybeNotVegan: string[]
+unknown: string[]
}
class IconClassType {
+vegan icon-ok
+non-vegan icon-cancel
+unknown-vegan icon-help
+maybe-vegan icon-attention-alt
}
class TranslationFunction {
+TranslationFunction(key: string, values?: Record<string, string>): string
}
IngredientsList --> TooltipClient
ResultDisplay --> IngredientsList
ResultDisplay --> IngredientResult
TooltipClient --> IconClassType
TooltipClient --> TranslationFunction
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.11.0 to 8.14.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.14.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…typescript-eslint/parser-8.14.0 build(deps-dev): bump @typescript-eslint/parser from 8.11.0 to 8.14.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @philipbrembeck - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bumps [eslint-plugin-react-compiler](https://github.com/facebook/react/tree/HEAD/compiler/packages/eslint-plugin-react-compiler) from 19.0.0-beta-8a03594-20241020 to 19.0.0-beta-63b359f-20241101. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/compiler/packages/eslint-plugin-react-compiler) --- updated-dependencies: - dependency-name: eslint-plugin-react-compiler dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 8.11.0 to 8.14.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.14.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…typescript-eslint/eslint-plugin-8.14.0 build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.11.0 to 8.14.0
…eslint-plugin-react-compiler-19.0.0-beta-63b359f-20241101 build(deps-dev): bump eslint-plugin-react-compiler from 19.0.0-beta-8a03594-20241020 to 19.0.0-beta-63b359f-20241101
Quality Gate passedIssues Measures |
Summary by Sourcery
Promote staging changes to production, including dependency updates, SCSS refactoring, and new end-to-end tests. Enhance the IngredientsCheck component with tooltips and update the Playwright configuration for better CI integration.
Enhancements:
Build:
CI:
Documentation:
Tests: