Avoid useless rescan : Detect if local lib files have changed after sync #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an when unneeded. make curl to use remote file date to allow detect file change with dates
ospring
changed the title
|
I still experience the issue (but i might be to lazy in the way i upgrade, dropping the new KoboRoot.tgz in the .kobo folder instead of uninstalling KoboCloud and after that installing it). If my upgrade method is not correct, please point me to the correct way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescan trigger after each sync seems to be the origin to issue #172. The PR add a comparaison of the content of the lib directory before and after the sync. The rescan will be launch only if the content has changed. Comparaison is done with the result of a detailed LS command (so, file name, size and dates).
To avoid the date of synced files to change after each sync, adding a --remote-time to the CURL command will allow to use the remote date of the file so if files are not changed remotely, dates on the local lib will stay the same and allow comparaison of the lib content to work as expected.