Codefactor issues 1

fsh-org · Dec 15, 2024 · 50449a9 · 50449a9
1 parent 981cb03
commit 50449a9
Show file tree

Hide file tree

Showing 20 changed files with 27 additions and 33 deletions.
diff --git a/apis/ad.js b/apis/ad.js
@@ -27,7 +27,7 @@ module.exports = {
             })
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/animal.js b/apis/animal.js
@@ -52,14 +52,8 @@ module.exports = {
         })
         break;
       case 'frog':
-        let uu = Math.floor(Math.random() * 54 + 1);
-        if (uu.length == 1) {
-          uu = "000" + uu
-        } else {
-          uu = "00" + uu
-        }
         res.json({
-          image: 'http://allaboutfrogs.org/funstuff/random/'+uu+'.jpg'
+          image: `http://allaboutfrogs.org/funstuff/random/${String(Math.floor(Math.random() * 54 + 1)).padStart(4, '0')}.jpg`
         })
         break;
       case 'bunny':

diff --git a/apis/ascii.js b/apis/ascii.js
@@ -17,7 +17,7 @@ module.exports = {
 
     let { width, height } = await image
       .metadata()
-      .catch(err => {
+      .catch(() => {
         res.error('Could not read');
         return;
       });
@@ -61,7 +61,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       });

diff --git a/apis/audio.js b/apis/audio.js
@@ -45,7 +45,7 @@ module.exports = {
             download: `https://api.fsh.plus/download/audio/${id}.mp3`
           })
         })
-        .on('error', (err) => {
+        .on('error', () => {
           res.error('Could not download', 500);
         });
     } catch (err) {

diff --git a/apis/bi.js b/apis/bi.js
@@ -31,7 +31,7 @@ module.exports = {
               })
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/biden.js b/apis/biden.js
@@ -32,7 +32,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate')
         return;
       })

diff --git a/apis/blur.js b/apis/blur.js
@@ -34,7 +34,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/colorify.js b/apis/colorify.js
@@ -46,17 +46,17 @@ module.exports = {
                   image: 'data:image/png;base64,' + outputBuffer.toString('base64')
                 })
               })
-              .catch(err => {
+              .catch(() => {
                 res.error('Could not generate', 500);
                 return;
               })
           })
-          .catch(err => {
+          .catch(() => {
             res.error('Could not create color layer', 500);
             return;
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not read image', 500);
         return;
       })

diff --git a/apis/communism.js b/apis/communism.js
@@ -31,7 +31,7 @@ module.exports = {
               })
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/deepfry.js b/apis/deepfry.js
@@ -44,12 +44,12 @@ module.exports = {
                   image: 'data:image/png;base64,' + outputBuffer.toString('base64')
                 })
               })
-              .catch(err => {
+              .catch(() => {
                 res.error('Could not generate', 500);
                 return;
               })
           })
-          .catch(err => {
+          .catch(() => {
             res.error('Could not generate', 500);
             return;
           })

diff --git a/apis/flip.js b/apis/flip.js
@@ -20,7 +20,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/flop.js b/apis/flop.js
@@ -20,7 +20,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/gay.js b/apis/gay.js
@@ -31,7 +31,7 @@ module.exports = {
               })
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/image-format.js b/apis/image-format.js
@@ -36,7 +36,7 @@ module.exports = {
           image: 'data:image/'+format+';base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/imagine.js b/apis/imagine.js
@@ -43,7 +43,7 @@ module.exports = {
       if (req.query["model"] == "dall-e") {
         let img = await fetch(`https://hercai.onrender.com/v3/text2image?prompt=${req.query["text"].replaceAll(" ","%20")}`);
         img = await img.json();
-        if ((String(img.status)??'2').startsWith('4')) {
+        if (!String(img.status).startsWith('2')) {
           res.error('Error, wait a bit or check prompt', 500);
           return;
         }

diff --git a/apis/join.js b/apis/join.js
@@ -6,7 +6,7 @@ let cache = {};
 
 async function getUrl(url) {
   if (!url.includes('://')) url = 'https://'+url;
-  return new Promise(async(resolve, reject) => {
+  return new Promise(async(resolve) => {
     if (!url) {
       resolve();
       return;
@@ -30,7 +30,7 @@ async function getUrl(url) {
       } else {
         resolve();
       }
-    } catch (err) { resolve(); }
+    } catch (err) { resolve() }
   });
 }
 
@@ -235,7 +235,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/pixelate.js b/apis/pixelate.js
@@ -43,12 +43,12 @@ module.exports = {
                   image: 'data:image/png;base64,' + outputBuffer.toString('base64')
                 })
               })
-              .catch(err => {
+              .catch(() => {
                 res.error('Could not generate', 500);
                 return;
               })
           })
-          .catch(err => {
+          .catch(() => {
             res.error('Could not generate', 500);
             return;
           })

diff --git a/apis/resize.js b/apis/resize.js
@@ -37,7 +37,7 @@ module.exports = {
           image: 'data:image/png;base64,' + outputBuffer.toString('base64')
         })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })

diff --git a/apis/video.js b/apis/video.js
@@ -82,7 +82,7 @@ module.exports = {
             })
           }
         })
-        .on('error', (error) => {
+        .on('error', () => {
           res.error('Could not download', 500);
         });
     } catch (err) {

diff --git a/apis/wanted.js b/apis/wanted.js
@@ -27,7 +27,7 @@ module.exports = {
             })
           })
       })
-      .catch(err => {
+      .catch(() => {
         res.error('Could not generate', 500);
         return;
       })
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ module.exports = { @@
                 })
               })
           })
-          .catch(err => {
+          .catch(() => {
             res.error('Could not generate', 500);
             return;
           })
@@ Expand Down @@