Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add work-around to load double sequence [1.0, 1.1]. #17

Merged
merged 1 commit into from
Dec 28, 2023
Merged

add work-around to load double sequence [1.0, 1.1]. #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- [Test](#test)
- [Build (Deprecated)](#build-deprecated)
- [Run](#run-1)
- [Known Issues](#known-issues)
- [Authors](#authors)
- [License](#license)

Expand Down Expand Up @@ -259,6 +260,12 @@ All of the test is listed with result as following
[ros2-2] [INFO] [1601447662.146011312] [client]: j. Test New Added Persistent Parameter Stores To File : PASS
```

## Known Issues

- [Error when loading a persistent parameter of type array<double>](https://github.com/fujitatomoya/ros2_persist_parameter_server/issues/13)
- `[1.0,1.1]` is deduced as `[1, 1.1000000000000001]` because of [yaml-cpp bug](https://github.com/jbeder/yaml-cpp/issues/1016), this will leads to `Failed to parse parameters` exception when loading the persistent parameters from yaml file.
- The work-around is to use string sequence `["1.0", "1.1"]` instead of double type, then change it into `float()` in the program.

## Authors

- **Tomoya Fujita** --- Tomoya.Fujita@sony.com
Expand Down