Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 16.2.0 for Fragments, Replace Unnecessary <div /> on HOC. #292

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

notadamking
Copy link

@notadamking notadamking commented Dec 4, 2018

Problem

The <div /> surrounding the <WrappedComponent /> causes styles to render incorrectly on the wrapped component.

Fix

Replace the <div /> with <React.Fragment /> to prevent stylistic changes.

I also removed unused lines of code from the GoogleApiComponent, and then ran make build to update the dist folder.

> google-maps-react@2.0.3 prepublish /Users/adam/Desktop/Projects/google-maps-react
> ./scripts/prepublish.sh

=> Transpiling...

src/GoogleApiComponent.js -> dist/GoogleApiComponent.js
src/components/Circle.js -> dist/components/Circle.js
src/components/HeatMap.js -> dist/components/HeatMap.js
src/components/InfoWindow.js -> dist/components/InfoWindow.js
src/components/Marker.js -> dist/components/Marker.js
src/components/Polygon.js -> dist/components/Polygon.js
src/components/Polyline.js -> dist/components/Polyline.js
src/index.js -> dist/index.js
src/lib/GoogleApi.js -> dist/lib/GoogleApi.js
src/lib/ScriptCache.js -> dist/lib/ScriptCache.js
src/lib/String.js -> dist/lib/String.js
src/lib/arePathsEqual.js -> dist/lib/arePathsEqual.js
src/lib/cancelablePromise.js -> dist/lib/cancelablePromise.js
src/lib/windowOrGlobal.js -> dist/lib/windowOrGlobal.js

=> Complete
@notadamking
Copy link
Author

Solves #227

@notadamking
Copy link
Author

Any reason this hasn't been merged?

@omcg33
Copy link

omcg33 commented May 30, 2019

Please merge with PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants