Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings by adding strict tsconfig.json #363

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fnune
Copy link

@fnune fnune commented Jul 17, 2019

Running npm run typecheck will run the TypeScript compiler without emitting files to check for type errors in index.d.ts

This PR will make google-maps-react compile properly in projects that use the strict tsconfig flag, and it won't break existing projects.

Running `npm run typecheck` will run the TypeScript compiler without
emitting files to check for type errors in index.d.ts
Due to strict mode on ES5 having a syntax error for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant