Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - Add usePersistentWatch flag to solrmonitor on top of the POC of permanent recusive watch PR #59

Open
wants to merge 1 commit into
base: patsonluk/zk-persistent-watch
Choose a base branch
from

Conversation

patsonluk
Copy link
Contributor

Description

This PR adds an extra usePersistentWatch flag to solrmonitor on top of the POC #58 .
Since the flag is default as false, it would revert to the old behavior of one-time, non recursive watch implementation of PRS enabled collection watching

This PR demonstrates:

  1. The code change required to support such flag that flips between persistent watch/one-time watch . Take note that for one-time watch, we are also forced to use non-recusive watch, as there's no recursive option for one-time watch
  2. The fetch count difference (as demonstrated in the unit test TestPRSProtocol) that persistent recursive watch does save on fetch count

@patsonluk patsonluk changed the title Add usePersistentWatch flag to solrmonitor on top of the POC of permanent recusive watch PR POC - Add usePersistentWatch flag to solrmonitor on top of the POC of permanent recusive watch PR Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant