Making WitherableWithIndex depend on FilterableWithIndex #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a natural extension, and it's nice not to pollute your codebase with unnecessary assumptions to have access to the functionality.
phadej
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Yes, this was an unfortunate oversight.
Unfortunately this is a breaking change, so there might be WitherableWithIndex instances without FilterableWithIndex instance. :(
OTOH, that might be a good opportunity to drop deprecated modules, so maybe not that bad.
phadej
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a natural extension, and it's nice not to pollute your codebase with unnecessary assumptions to have access to the functionality.