Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cache PR build results based on git tree hash #119

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

kaspar030
Copy link
Collaborator

@kaspar030 kaspar030 commented Feb 24, 2024

So currently, a branch gets built at lest three times: first on the PR, second in the merge queue and third for the master push event.

This PR adds result caching to the "CI build step" that caches positive build results.

edit So it turns out that there are quite strict restrictions on inter-branch cache access. "main" builds cannot access caches generated from child branches (PRs). :(

@kaspar030
Copy link
Collaborator Author

So this is hard to test I think. I'll try to re-run.

@kaspar030
Copy link
Collaborator Author

So if the cache doesn't 429, it seems to work at least on PR run reruns.

@kaspar030 kaspar030 added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit f8cdca1 Feb 24, 2024
16 checks passed
@kaspar030 kaspar030 deleted the ci/cache-builds branch February 24, 2024 11:45
@ROMemories ROMemories added the CI label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants