riot-rs-macros: use thread_create_noarg() in thread macro
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROMemories
reviewed
Mar 5, 2024
ROMemories
requested changes
Mar 5, 2024
kaspar030
force-pushed
the
thread_macro_use_create_raw
branch
from
b9dcd4c
to
c6b8d31
Compare
kaspar030
force-pushed
the
thread_macro_use_create_raw
branch
from
c6b8d31
to
9387590
Compare
|
Like this? |
ROMemories
approved these changes
Mar 5, 2024
kaspar030
changed the title
thread_create_raw() in thread macrothread_create_noarg() in thread macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the thread macro use
thread_create_raw()instead ofthread_create().While
thread_create_raw()is unsafe, this drops the need for the trampoline function.IMO that makes debugging more natural, as e.g., thread function
module::fn_name()ends up called like that in the linker output, and notmodule::__start_thread_fn_name::trampoline().