riot-rs-threads: cortex_m: make sched() less hacky
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(marked as draft as this needs testing) |
elenaf9
reviewed
Mar 15, 2024
elenaf9
reviewed
Mar 15, 2024
elenaf9
reviewed
Mar 15, 2024
|
Friendly ping @kaspar030. Is anything blocking this PR? I am currently working on an alternative implementation of #241, where these changes are relevant. Happy to take over the PR and do the rebasing/ solving of merge conflicts. |
kaspar030
force-pushed
the
improve_cortex_m_sched
branch
from
261b128
to
e3966d2
Compare
I've rebased the PR and updated it to support the |
kaspar030
force-pushed
the
improve_cortex_m_sched
branch
from
e3966d2
to
67d5a40
Compare
elenaf9
added a commit
to elenaf9/RIOT-rs
that referenced
this pull request
May 3, 2024
Refactor `arch::cortex_m::sched`, based on future-proof-iot#187. The previous implementation didn't use `CriticalSection` correctly, which allowed two threads on different cores to enter `sched` at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the previusly manual critical section into
sched(), and uses a "u128" to pass our values to the assembly.(this adds an instruction or two, but on nrf52840dk, this is barely measurable).