Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/coap): Enable again #469

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chrysn
Copy link
Collaborator

@chrysn chrysn commented Oct 16, 2024

Description

This reverts d351ee8 / PR447.

Issues/PRs references

There have been issues with libOSCORE when building with clang 18, due to which the example has been disabled in #447; #443 proposes to update to a libOSCORE that works with (but also requires) clang 18.

The single commit in this is also part of #443 now.

Change checklist

  • I have cleaned up my commit history and squashed fixup commits.
  • I have followed the Coding Conventions.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

This is a draft PR because I need to see whether CI maybe went back on the clang 18 update (#443 only works if everything is clang 18). Only one of those makes sense.

@kaspar030
Copy link
Collaborator

I guess as soon as this passes CI it can be merged.

@kaspar030 kaspar030 mentioned this pull request Oct 24, 2024
4 tasks
@chrysn chrysn force-pushed the reenable-oscore-without-c23 branch from 221cc50 to 73479f6 Compare October 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants