Skip to content

Commit

Permalink
Release v1.7.4
Browse files Browse the repository at this point in the history
Don't customize the badge tooltip in Edge when showing the tab count.  Edge started automatically appending the badge text after the tooltip, which looks strange after text that also lists the tab count.
Suppress devtools console errors in Chromium v102.
Update releases/index.md.
  • Loading branch information
fwextensions committed Jun 18, 2022
1 parent 3f7b355 commit 5b100f6
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 4 deletions.
8 changes: 8 additions & 0 deletions docs/releases/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ comments: true
# Release history


## 1.7.4 - 2022-06-18

### Fixed

* In Microsoft Edge, don't show a tab count in the badge tooltip, since Edge now automatically appends the badge number.
* Suppress the harmless but annoying devtools console errors that were triggered by [a bug in Chromium v102](https://chromium-review.googlesource.com/c/v8/v8/+/3660253).


## 1.7.3 - 2022-06-18

### Fixed
Expand Down
5 changes: 4 additions & 1 deletion src/js/background/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,10 @@ require([
const text = showTabCount
? String(tabCount)
: "";
const title = showTabCount
// Edge appends the badge count with a comma after the badge title,
// which looks awkward: "829 open tabs, 829". so don't customize
// the title in Edge.
const title = showTabCount && !k.IsEdge
? `${name} - ${tabCount} open tab${tabCount == 1 ? "" : "s"}`
: name;

Expand Down
15 changes: 14 additions & 1 deletion src/js/lib/error-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@

if (event.preventDefault) {
event.preventDefault();

// add a flag so we know that preventDefault() was called while
// we were queuing errors, and not by the console errors that
// Chromium v102 triggers
event.queued = true;
}
}

Expand Down Expand Up @@ -49,6 +54,15 @@
function handleError(
event)
{
if (event.defaultPrevented && !event.queued) {
// the devtools console in Chromium v102 triggers
// unhandled errors while you type, with defaultPrevented
// set to true. so ignore those errors, but only if
// they weren't queued while we were starting up, which
// mean they're legitimate.
return;
}

try {
const timestamp = new Date().toLocaleString();
const {detail, reason = ((detail && detail.reason) || "")} = event;
Expand All @@ -69,7 +83,6 @@
}
}


// fire exception stats for any queued errors
errors.forEach(handleError);
errors = null;
Expand Down
4 changes: 2 additions & 2 deletions src/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"manifest_version": 2,
"name": "QuicKey DEV",
"short_name": "QuicKey DEV",
"version": "1.7.3",
"version": "1.7.4",
"description": "Add keyboard shortcuts to switch tabs with a Quicksilver-style search or a most recently used menu",
"author": "John Dunning",
"content_security_policy": "script-src 'self' 'unsafe-eval' https://www.google-analytics.com; object-src 'self'",
Expand Down Expand Up @@ -66,4 +66,4 @@
}
},
"offline_enabled": true
}
}

0 comments on commit 5b100f6

Please sign in to comment.