Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup for handling of disabled animations #5251

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Nov 12, 2024

Description:

Just a very simple cleanup PR to move the no_animations tag handling to use existing infrastructure in the internal/build package. The biggest win here is reducing the number of files in the app package but it might theoretically (due to now using a constant for the value) also help the compiler deadcode eliminate more branches when building without animations (although the latter is unlikely to matter in most cases).

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.958%. remained the same
when pulling 370d051 on Jacalz:no_animations
into 85063d5 on fyne-io:develop.

Copy link
Contributor

@sdassow sdassow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. And always glad to avoid init().

@Jacalz Jacalz merged commit 9476f0f into fyne-io:develop Nov 20, 2024
12 checks passed
@Jacalz Jacalz deleted the no_animations branch November 20, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants