Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing arrow key mapping for mobile devices #5276

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add missing arrow key mapping for mobile devices #5276

merged 1 commit into from
Nov 20, 2024

Conversation

andydotxyz
Copy link
Member

Fixes #5258

Checklist:

  • Tests included. <- no infra for mobile hardware tests. Use any mobile device with a keyboard or use "-tags mobile" and use the arrow keys
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.996% (+0.009%) from 59.987%
when pulling f28bb2b on andydotxyz:fix/5258
into b3f9766 on fyne-io:develop.

sdassow
sdassow approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@sdassow sdassow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andydotxyz andydotxyz merged commit b529a32 into fyne-io:develop Nov 20, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/5258 branch November 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdassow sdassow sdassow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @sdassow