Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add languages to metadata and use for language integration in macOS #5279

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Nov 20, 2024

Description:

Recent macOS versions offer support for selecting a language per application, and this PR is working towards integrating with that.

This is the first step to solve #5277 and this PR makes the language drop-down available, but the app itself does not seem to get it yet, so there seems to be more to it.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 59.989% (+0.009%) from 59.98%
when pulling 6b01710 on sdassow:macos-language-integration
into b529a32 on fyne-io:develop.

@sdassow sdassow changed the title WIP: Look up available languages in source directory to provide to macOS Add languages to metadata and use for language integration in macOS Nov 20, 2024
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this nice new feature - but check out bundle.go changes before pushing!

cmd/fyne/internal/templates/bundled.go Outdated Show resolved Hide resolved
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks

@sdassow sdassow merged commit 6bfd026 into fyne-io:develop Nov 21, 2024
12 checks passed
@sdassow sdassow deleted the macos-language-integration branch November 21, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants