Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the issue: form validation message not working on unfocus #5321

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for the issue: form validation message not working on unfocus #5321

wants to merge 1 commit into from

Conversation

coder-in-go
Copy link

@coder-in-go coder-in-go commented Dec 16, 2024 •
edited
Loading

Description:
This PR addresses the issue where the form validation message was not triggering upon field unfocused.

Fixes #4138

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member

@coder-in-go I hope you appreciate we cannot approve work where so many tests are failing.
It may be just 1 change but it either needs to be resolved in the code, or a test that was wrong should be fixed. Seeing most of them fail in the same way it clearly isn't an intermittent error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coder-in-go @andydotxyz