Bug fixes #109
Open
Bug fixes #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 19, 2021 12:25
Noise blanker was not updated when selected. New coefficients taken from dl1ycf experiments with pihpsdr.
During extensive monitoring of HL2 packets to/from linHPSDR, it was noted that sometimes there were delays in packets being processed by linHPSDR. This gives high priority to the socket
Not a bug fix. Move repeated mode calls into a query function in transmitter.c
Perhaps this is by design? However, currently, the radio_info button for CAT displays active when CAT daemon is enabled. This only sets active when a client has connected to that RX cat daemon.
audio.c
Outdated
| @@ -1035,7 +1004,7 @@ fprintf(stderr,"mic_read_thread: ALSA: mic_buffer_size=%d\n",radio->local_microp | |||
| //g_print("mic_read_thread: -EPIPE: snd_pcm_prepare\n"); | |||
| if ((rc = snd_pcm_prepare (r->record_handle)) < 0) { | |||
| g_print("mic_read_thread: ALSA: cannot prepare audio interface for use %d (%s)\n", rc, snd_strerror (rc)); | |||
| return rc; | |||
| //return rc; | |||
There was a problem hiding this comment.
Dubious change. This changes the flow, this function should abort on error. Correct would be a plain return;
|
This has merge conflicts, also there is the change in return flow. Putting on the backlog, but it looks like there's many valuable fixes in there. |
|
@andreasdotorg thanks for your review. I believe I have resolved the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit titles describe changes made. Sticking to one fix per commit.