Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/improve representation of GKS Core Domain Entities (Disease, Phenotype, Condition) #104

Open
mbrush opened this issue Dec 12, 2022 · 0 comments

Comments

@mbrush
Copy link
Contributor

mbrush commented Dec 12, 2022

Modeling of these domain entities for the metakb-cvc implementation work defined separate classes for these concepts that make distinctions inconsistent with how the VA team has thought about and modeled Genetic Conditions more generally. e.g. metakb-cvc Conditions are specifically defined to necessarily include a collection of >1 Disease or Phenotype.

On the Aug 30 2022 VA call, there was consensus that this approach - while practical for the current metakb work, is semantically inconsistent with how these concepts are understood. We will return to refactor / align representations after the plenary/connect meetings.

@mbrush mbrush changed the title Align representation of GKS Core Disease, Phenotype, Condition classes with VA GeneticCondition modeling Refactor/improve representation of GKS Core Domain Entities (Disease, Phenotype, Condition) Dec 14, 2022
@ahwagner ahwagner transferred this issue from ga4gh/gks-metaschema Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant