Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conventions for multivalued attributes #97

Open
1 task
mbrush opened this issue Jan 11, 2023 · 2 comments
Open
1 task

Naming conventions for multivalued attributes #97

mbrush opened this issue Jan 11, 2023 · 2 comments

Comments

@mbrush
Copy link
Contributor

mbrush commented Jan 11, 2023

Should we generally adhere to the convention that attributes that can be multivalued (i.e. cardinality of 0..m or 1..m) should have plural names where applicable (e.g. references not reference, aleternativeLabels not alternativeLabel, contributions not contribution)

Note that there are some cases where we cannot pluralize the name of a multivalued attribute, based on how we have chosen to name the field. e.g. specifiedBy, or isAbout, or performedBy.

To Do:

  • Go through all attributes in the model and rename according to the conventions we adopt here. At present there is some inconsistency.
@sivangbagri
Copy link

@mbrush is this still open ?

@larrybabb
Copy link
Contributor

@mbrush I think we all agree this is a good convention. do we need to keep this open or can we declare that when we identify any inconsistencies in this practice we will fix them?

Do you want to take the To Do on above (or have you already)? Please assign to yourself, unless you don't feel like you can take this on? Also, if you've done this work already, please go ahead an close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants