Set BytesType to 8 bytes for BIT since size is 1<=M<=64

gabledata · Aug 10, 2023 · 92d03c2 · 92d03c2
1 parent 3a74cbf
commit 92d03c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/recap/readers/mysql.py b/recap/readers/mysql.py
@@ -58,8 +58,7 @@ def get_recap_type(self, column_props: dict[str, Any]) -> RecapType:
             byte_length = ceil(max_length / 8)
             base_type = BytesType(bytes_=byte_length, variable=False)
         elif data_type.startswith("bit"):
-            byte_length = ceil(max_length / 8)
-            base_type = BytesType(bytes_=byte_length, variable=False)
+            base_type = BytesType(bytes_=8, variable=False)
         elif data_type.startswith("timestamp") or data_type.startswith("datetime"):
             dt_precision = column_props["DATETIME_PRECISION"]
             unit = self._get_time_unit([dt_precision]) or "microsecond"

diff --git a/tests/integration/readers/test_mysql.py b/tests/integration/readers/test_mysql.py
@@ -118,7 +118,7 @@ def test_struct_method(self):
             UnionType(
                 default=None,
                 name="test_bit",
-                types=[NullType(), BytesType(bytes_=2, variable=False)],
+                types=[NullType(), BytesType(bytes_=8, variable=False)],
             ),
             UnionType(
                 default=None,