feat: distinguish between different connectiont types

gajus · Mar 27, 2017 · 8407806 · 8407806
1 parent 5ebcf55
commit 8407806
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -13,16 +13,19 @@ import {
   NotFoundError
 } from './errors';
 import type {
-  InternalQueryInsertType,
+  DatabasePoolConnectionType,
+  DatabaseSingleConnectionType,
   InternalQueryAnyType,
-  InternalQueryOneType,
+  InternalQueryInsertType,
   InternalQueryManyType,
-  InternalQueryType,
-  DatabaseConnectionType
+  InternalQueryOneType,
+  InternalQueryType
 } from './types';
 
 export type {
-  DatabaseConnectionType
+  DatabaseConnectionType,
+  DatabasePoolConnectionType,
+  DatabaseSingleConnectionType
 } from './types';
 
 export {
@@ -114,7 +117,7 @@ export const any: InternalQueryAnyType = async (connection, sql, values) => {
 };
 
 // eslint-disable-next-line flowtype/no-weak-types
-const createConnection = async (configuration: Object): Promise<DatabaseConnectionType> => {
+const createConnection = async (configuration: Object): Promise<DatabaseSingleConnectionType> => {
   const connection = await createConnection2(configuration);
 
   return {
@@ -130,7 +133,7 @@ const createConnection = async (configuration: Object): Promise<DatabaseConnecti
 };
 
 // eslint-disable-next-line flowtype/no-weak-types
-const createPool = (configuration: Object): DatabaseConnectionType => {
+const createPool = (configuration: Object): DatabasePoolConnectionType => {
   const pool = createPool2(configuration);
 
   return {

diff --git a/src/types.js b/src/types.js
@@ -5,13 +5,18 @@
 // eslint-disable-next-line flowtype/no-weak-types
 type InternalDatabaseConnectionType = any;
 
-export type DatabaseConnectionType = {|
+export type DatabaseSingleConnectionType = {
+  end: () => Promise<void>
+} & DatabaseConnectionType;
+export type DatabasePoolConnectionType = DatabaseConnectionType;
+
+export type DatabaseConnectionType = {
   +any: QueryAnyType,
   +insert: QueryInsertType,
   +many: QueryManyType,
   +one: QueryOneType,
   +query: QueryType
-|};
+};
 
 type QueryPointResultType = {|
   +x: number,