Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sslMode with current libpq-connect options #641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wasd171
Copy link

@wasd171 wasd171 commented Aug 26, 2024

This PR aligns TypeScript types with current libpq-connect options

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 494b382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@slonik/types Major
@slonik/driver Major
@slonik/errors Major
@slonik/pg-driver Major
@slonik/dataloaders Major
@slonik/sql-tag Major
@slonik/utilities Major
@slonik/benchmark Major
slonik-interceptor-field-name-transformation Major
slonik-interceptor-query-cache Major
slonik-interceptor-query-logging Major
slonik-sql-tag-raw Major
slonik Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wasd171
Copy link
Author

wasd171 commented Aug 28, 2024

@gajus I initially just wanted to fix the types but it looks like some code actually uses the no-verify value. Given that it is not mentioned anymore in the docs I suppose it would also be OK to remove it from the code?

Probably the logic should be that we only check the CA for 'verify-ca' | 'verify-full' and 'allow' | 'prefer' | 'require' should set rejectUnauthorized: false

Might be relevant: brianc/node-postgres#2709

@wasd171
Copy link
Author

wasd171 commented Sep 22, 2024

@gajus I would still like to move forward with this PR, but no-verify seems like more of a product decision. Would you prefer to retain it or can I remove it not only from the types, but also from the codebase?

@gajus
Copy link
Owner

gajus commented Sep 24, 2024

Happy to remove it.

Will ship as a major version upgrade since it is breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants