Position interpolation was broken - fix it #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit edc8a2c broke interpolation of N-body positions because: 1. Any set position was ignored in favor of a position drawn from the `positionHistory` if available; 2. The `nodeOperatorPositionInterpolated` class was computing the interpolation but never actually setting the position. Additionally, lightcone classes, which rely on this interpolation to find the exact time of lightcone crossing, were no longer getting interpolated position as they simply updated the `basis%time()` property. This used to work, but with the refactoring in commit edc8a2c we instead need to call the `solveAnalytics` method of the `nodeOperator` to set the positions.
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit edc8a2c broke interpolation of N-body positions because:
Any set position was ignored in favor of a position drawn from the
positionHistoryif available;The
nodeOperatorPositionInterpolatedclass was computing the interpolation but never actually setting the position.Additionally, lightcone classes, which rely on this interpolation to find the exact time of lightcone crossing, were no longer getting interpolated position as they simply updated the
basis%time()property. This used to work, but with the refactoring in commit edc8a2c we instead need to call thesolveAnalyticsmethod of thenodeOperatorto set the positions.