Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize starFormationRateSurfaceDensityDisksBlitz2006 table construction #689

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

abensonca
Copy link
Collaborator

Previously, objects kept independent copies of this table and never tried to re-read the version from file. This meant that, if the file had been updated, an object would ignore it, recompute the table itself, and write it out. This lead to inefficiency as the new table might not have as large extent as the version it overwrote.

Now, the file is re-read whenever the current table owned by an object is insufficient.

…construction

Previously, objects kept independent copies of this table and never tried to re-read the version from file. This meant that, if the file had been updated, an object would ignore it, recompute the table itself, and write it out. This lead to inefficiency as the new table might not have as large extent as the version it overwrote.

Now, the file is re-read whenever the current table owned by an object is insufficient.
@abensonca abensonca self-assigned this Sep 5, 2024
@abensonca abensonca added this pull request to the merge queue Sep 6, 2024
Merged via the queue into master with commit 844c5bc Sep 6, 2024
285 checks passed
@abensonca abensonca deleted the featOptimizeBlitzTable branch September 6, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant