Track the last modified commit hash in parameter files #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `version` element in parameter files is now replaced with a `lastModified` element that tracks both the time at which the file was last modified, and the `git` commit hash for which it was intended. At run time, this is now used to check if the parameter file is out of date (i.e. is missing parameter migrations), or if the executable is out of date. To facilitate this, the parameter migration data is no longer embedded in the `parametersMigrate.pl` script, but is stored in its own XML file.
|
|
|
|
…rs from Galacticus output files
|
|
|
|
Needed to convince `XML::Simple` to parse the file.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
versionelement in parameter files is now replaced with alastModifiedelement that tracks both the time at which the file was last modified, and thegitcommit hash for which it was intended. At run time, this is now used to check if the parameter file is out of date (i.e. is missing parameter migrations), or if the executable is out of date.To facilitate this, the parameter migration data is no longer embedded in the
parametersMigrate.plscript, but is stored in its own XML file.