Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UP031 errors - Part 4 #19235

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix UP031 errors - Part 4 #19235

merged 2 commits into from
Dec 4, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Dec 3, 2024

Also:

  • Add related type annotations.
  • Don't unnecessarily copy list in listify().

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Dec 3, 2024
@github-actions github-actions bot added this to the 25.0 milestone Dec 3, 2024
@nsoranzo
Copy link
Member Author

nsoranzo commented Dec 3, 2024

Test failures unrelated.

@nsoranzo nsoranzo requested a review from a team December 4, 2024 01:07
@nsoranzo nsoranzo merged commit b5a25f0 into galaxyproject:dev Dec 4, 2024
53 of 57 checks passed
@nsoranzo nsoranzo deleted the fix_UP031_errors_pt4 branch December 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/datatypes area/security area/testing/selenium area/testing area/tool-dependencies area/tool-framework area/util kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @davelopez