Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow moving activity bar icons when editing the bar. #19239

Closed
wants to merge 1 commit into from

Conversation

jmchilton
Copy link
Member

Add small visual indicator that they can be moved.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Try to move the icons outside of the settings panel - notice they don't.
    2. Click activity bar settings - notice the icons can now be moved and have a small dashed border.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Add small visual indicator that they can be moved.
@dannon
Copy link
Member

dannon commented Dec 3, 2024

Thanks! Want to target 24.2?

@jmchilton
Copy link
Member Author

@dannon I was going to wait for #19212 to be merged. I've already conflicted it twice and this would again.

@jmchilton jmchilton closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants