-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of Teloscope #6556
base: main
Are you sure you want to change the base?
Conversation
In order to get the tests running here you need to add a |
…nto add-shed-yaml
Added .shed.yml, updated teloscope.xml, and added test-data
Added missing macros.xml
</xml> | ||
<token name="@TOOL_VERSION@">0.0.5</token> | ||
<token name="@VERSION_SUFFIX@">0</token> | ||
<token name="@PROFILE@">21.05</token> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer something in the range of 23.0 or 23.2
<token name="@PROFILE@">21.05</token> | ||
<xml name="citations"> | ||
<citations> | ||
<citation type="bibtex"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No publication?
@@ -0,0 +1,108 @@ | |||
<tool id="teloscope" name="Teloscope" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="@PROFILE@"> | |||
<description>is a fast and comprehensive tool for matching, counting, and reporting telomeric repeats from genome assemblies.</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the description as short as possible: analyze telomeric repeats
</macros> | ||
<expand macro="requirements"/> | ||
<command detect_errors="exit_code"><![CDATA[ | ||
mkdir -p output && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation seems off
<param argument="--verbose" type="boolean" truevalue="--verbose" falsevalue="" checked="false" label="Verbose output"/> | ||
</inputs> | ||
<outputs> | ||
<data name="canonical_matches" format="bed" from_work_dir="output/canonical_matches.bed" label="Canonical matches from ${on_string}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few outputs. Can some of them be optional? I would prefer labels of the form ${tool.name} on ${on_string}: ...
]]></command> | ||
<inputs> | ||
<param argument="--input-sequence" type="data" format="fasta,fasta.gz" label="Input assembly"/> | ||
<param argument="--canonical" type="text" value="TTAGGG" label="Canonical pattern"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a canonical pattern?
<valid initial="string.ascii_letters"/> | ||
</sanitizer> | ||
</param> | ||
<param argument="--patterns" type="text" value="TTAGGG" label="Patterns to explore, separated by commas"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation.
<param argument="--input-sequence" type="data" format="fasta,fasta.gz" label="Input assembly"/> | ||
<param argument="--canonical" type="text" value="TTAGGG" label="Canonical pattern"> | ||
<sanitizer invalid_char=""> | ||
<valid initial="string.ascii_letters"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be more specific than ASCII letters, or?
</test> | ||
</tests> | ||
<help><![CDATA[ | ||
teloscope [commands] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer not to have just command line help.
I get more and more reluctant to include completely undescribed software (at least I found no docs), I understand that this software comes from a respectful source. And probably users don't care anyway as long as the software does what they expect.
It's unsatisfying.
We should at the very least open an upstream issue that some docs would be nice.
FOR CONTRIBUTOR: