Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seurat Tool FIlter Plot & Explore edits by Author #4988

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Camila-goclowski
Copy link
Contributor

@Camila-goclowski Camila-goclowski commented Jun 3, 2024

  • added answer and input histories
  • changed Pablo to infastructure contribution

- changed Pablo to infastructure contribution
- added answer and input histories 

working on adding workflow (searching for id)
@shiltemann
Copy link
Member

Hi @Camila-goclowski! Thanks for adding this. Please just add your workflow file in the GTN, we can merge it without test for now, and then we will help you to get the tests added in a later PR, does that sound good?

@shiltemann shiltemann marked this pull request as ready for review June 5, 2024 08:21
@shiltemann shiltemann requested a review from a team as a code owner June 5, 2024 08:21
wee-snufkin and others added 10 commits June 17, 2024 03:17
…euratTools/tutorial.md

Co-authored-by: wee-snufkin <44121095+wee-snufkin@users.noreply.github.com>
…euratTools/tutorial.md

Co-authored-by: wee-snufkin <44121095+wee-snufkin@users.noreply.github.com>
…rom-uploaded-file).ga

added ORCID for Camila
…rom-uploaded-file)-test.yml

Trying to skip workflow test to get merged
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Camila-goclowski! A few suggestions inline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rename this file and also the workflow to have a nice name. Without ()' and the imported from ...

@@ -0,0 +1,13 @@
GTN_RUN_SKIP_REASON #Saskia approved
- doc: Test outline for Workflow-constructed-from-history-'Tool-based-FPE'-(imported-from-uploaded-file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- doc: Test outline for Workflow-constructed-from-history-'Tool-based-FPE'-(imported-from-uploaded-file)
- doc: Test for the Seurat Filter, Plot and Explore tutorial

"format-version": "0.1",
"license": "CC-BY-4.0",
"format-version": "0.1",
"name": "Workflow constructed from history 'Tool based FPE' (imported from uploaded file)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Workflow constructed from history 'Tool based FPE' (imported from uploaded file)",
"name": "Seurat Filter, Plot and Exlore tutorial",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants