Screens/social profile screen #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #31 |
hetmann
reviewed
Nov 12, 2018
palingheorghe
requested changes
Nov 12, 2018
There was a problem hiding this comment.
Hi,
Nice! This looks awesome! Could you expand on the issues you encountered?
You've done a great job! I'm glad you found it easy and cool to work with Galio ❤️.
When I first opened your screen's file I noticed there are 54 eslint errors, could you fix them?
Thanks,
Alin 🤙🏽
|
@samcyn a quick check for lint is to run |
|
update: All linting errors have been fixed. Thanks @hetmann and @palingheorghe for the review. |
palingheorghe
approved these changes
Nov 15, 2018
|
Hi one more change. I added COLOR_DARK_GREY='#444444' as suggested by @hetmann. And that should be all for now. Thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Social Profile Screen
I am done with this screen and would like some reviews on the work done. I enjoyed using Galio a lot. If not for the issues I had picking out some detailed measurements from the designs I would be done in a day or so. Well check out what I got and let me know what you think.
Regards.