Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option for uniform lighting #561

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

MShinkle
Copy link
Contributor

@MShinkle MShinkle commented Dec 4, 2024

Discussed in #560, this adds a simple option to enforce uniform lighting (no shadows or specularity) within pycortex webgl viewers. This is turned on by adding uniform_illumination = true to the user config file.

This option is set to false by default, so lighting should remain as it currently is unless this option is changed to true.

@mvdoc
Copy link
Contributor

mvdoc commented Dec 5, 2024

I understand this can be too much, but I'll ask anyway because why not ;)
Do you think you could add a button in the UI to enable/disable this option?
I think in this way we'll be able to expose this flag to cortex.export.save_view too, so it will make it easy to automate the generation of figures with uniform lighting.

@MShinkle
Copy link
Contributor Author

MShinkle commented Dec 5, 2024

Good idea! I haven't tested it with cortex.export.save_view, but I just added a commit that adds a toggle box for this illumination option in the UI.

@mvdoc
Copy link
Contributor

mvdoc commented Dec 5, 2024

Awesome, thank you!

@mvdoc mvdoc merged commit ff58a7e into gallantlab:main Dec 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants