Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues found when upgrading homepage #457

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

kathywklee
Copy link
Contributor

Changes

This PR is to fix the issues found in #418.
To keep the changes small, this PR is more on making the page work.

  • Code changes in Upgrade Homepage #412
  • Added SVGs and change color based on the current theme
  • Standardize section title
  • Add background for the developer logos in "Developers that chose us"
  • Fix background issue of pricing calculator
  • Improvements on HTML tag & structure
  • Optimize image

Note: I am not able to reproduce the GameCI logo issue (first item in #418) as I can't use Safari. I believe it is not related to the #412 though.

Desktop:

GameCI.-.desktop.mp4

Mobile:

GameCI.-.mobile.mp4

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

EliasVal and others added 8 commits March 24, 2024 16:21
* chore: upgrade docusaurus / fix deprecations

* chore: upgrade docusaurus / fix deprecations

* feat: introduce v3

* chore: upgrade node in ci

* Reconcile v2 and v3 docs with latest unity builder changes. Remove parameters not available in v2 from v2 docs.

* Remove parameters and outputs from v2.2.0-pre

* Update version tags to align with new version

* chore: upgrade docusaurus tsconfig

* chore: import/order

* fix: unresolved import

* chore: versions as client-side block

* fix: firebase resolution

* Re-enable sections, Prettier readme, use LF line endings

* Upgraded getting-started.tsx
- Upgraded getting-started.tsx to use company SVGs instead of text
- Moved getting-started.tsx section up
- Updated node16 references to node18 in .md files

* Revamped versions page

* INCOMPLETE: Changed out Ant's table

* Starting Section Rework
- Reworked Starting/Opening Section
- Began Working on pricing calculator
- Changed JSX.Element (dep.) -> React.JSX.Element

* Created tooltip component
- Created tooltip.tsx
- Centered VSC buttons in Getting Started

* Devs that chose us section
- Moved GH, GL, CCI SVGs to /static/assets/images/icons
- 'Finished' Devs that chose us section (more logos needed)
- Reintroduced '.vscode' directory from .gitignore to support @apply rule

* Docker versions progress
- Finished expandable menu
- Only left to implement a Tooltip and DockerImageLinkOrRetryButton (will leave this one to webber)

* Tooltip & Docker Table finished

* pricing section

* disabled unused sections

* resolved requests

---------

Co-authored-by: Webber <webber@takken.io>
Co-authored-by: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com>
Co-authored-by: Gabriel Le Breton <lebreton.gabriel@gmail.com>
Copy link

Cat Gif

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The pricing calculator could probably still be made to look more legit.

@webbertakken webbertakken merged commit e3cec5b into game-ci:main Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants