Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unity path #552

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

VioletXF
Copy link
Contributor

@VioletXF VioletXF commented Jul 27, 2023

Changes

Sorry, I was stupid. I tested my previous work(#551) on a cached environment and thought I'd done testing installation.

  • Add quotes back to unity path
  • Replace quotes on existsSync check

Sorry again to everyone for pushing the failing code

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
    a PR in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@VioletXF VioletXF force-pushed the fix/macos-unity-path-escape branch from 0374d67 to de94250 Compare July 27, 2023 19:33
@VioletXF VioletXF marked this pull request as ready for review July 27, 2023 19:54
@codecov-commenter
Copy link

Codecov Report

Merging #552 (9bf64ad) into main (21da302) will not change coverage.
The diff coverage is n/a.

❗ Current head 9bf64ad differs from pull request most recent head 53c5312. Consider uploading reports for the commit 53c5312 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files          77       77           
  Lines        3032     3032           
  Branches      586      586           
=======================================
  Hits         1121     1121           
  Misses       1908     1908           
  Partials        3        3           

@webbertakken
Copy link
Member

No worries at all. Let's just focus on getting the fix in :)

Thanks a lot for your quick response!

@webbertakken webbertakken merged commit f433356 into game-ci:main Jul 27, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants