Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parity with unity builder image version regex #267

Merged
merged 1 commit into from
May 7, 2024
Merged

Parity with unity builder image version regex #267

merged 1 commit into from
May 7, 2024

Conversation

AndrewKahr
Copy link
Member

Changes

  • Fix image tag checks for Unity 6+

Checklist

  • Read the contribution guide and accept the code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@AndrewKahr AndrewKahr enabled auto-merge (squash) May 7, 2024 09:07
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Cat Gif

@AndrewKahr AndrewKahr merged commit 5817131 into main May 7, 2024
86 checks passed
@AndrewKahr AndrewKahr deleted the fix-image-tag branch May 7, 2024 10:08
@GabLeRoux
Copy link
Member

I reviewed this after it god merged, but it looks good to me 👍 Thanks for bringing Unity 6 support in here 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbertakken webbertakken webbertakken approved these changes

@davidmfinol davidmfinol Awaiting requested review from davidmfinol

@GabLeRoux GabLeRoux Awaiting requested review from GabLeRoux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewKahr @GabLeRoux @webbertakken