feat: support private scoped registry on ubuntu #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@GabLeRoux curious to get our input on this and the related issue I created/attached. Thanks! 🙏 |
tobocop2
approved these changes
May 31, 2024
3 tasks
satwal
approved these changes
Jun 3, 2024
|
Apologies for my coworkers reviews, I shared the PR with them among some others and they reviewed thinking it was going into our fork 😅 |
davidmfinol
approved these changes
Jun 3, 2024
webbertakken
approved these changes
Jun 3, 2024
|
Released as part of https://github.com/game-ci/unity-test-runner/releases/tag/v4.3.0 |
|
Damn, that was fast. You guys rock 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.upmconfig.tomlpreviously used for package testing, to outside the scope of package testing to support projects which contain private scoped registries. The caveats remain the same for packages, that right now it is only supported on Linux runners, and only a single private registry is supported.Related Issues
Related PRs
Successful Workflow Run Link
PRs don't have access to secrets so you will need to provide a link to a successful run
of the workflows from your own repo.
main.ymlto only run a single test on a Professional license to show it pass, or we could discuss any other options like sharing screenshots of action passing from private repo.Checklist
in the documentation repo)