Fix PS gyro for values at the boundaries #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
src/uhid/joypad_ps5.cpp
Outdated
Comment on lines
368
to
372
| if (value < SHRT_MIN) { | ||
| value = SHRT_MIN; | ||
| } else if (value > SHRT_MAX) { | ||
| value = SHRT_MAX; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (value < SHRT_MIN) { | |
| value = SHRT_MIN; | |
| } else if (value > SHRT_MAX) { | |
| value = SHRT_MAX; | |
| } | |
| value = std::clamp(value, SHRT_MIN, SHRT_MAX); |
Could you simplify to this?
There was a problem hiding this comment.
Kind of, you'll have to cast to float because SHRT_MIN/MAX are unsigned int.
I agree though it looks cleaner using clamp, I'm going to commit that!
ReenigneArcher
approved these changes
Nov 9, 2024
|
I've tested this out a bit in-game, and it seems to work as it used to without the PR (at least on my setup). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: LizardByte/Sunshine#3247