Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove New function #33

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove New function #33

merged 1 commit into from
Nov 15, 2024

Conversation

gammazero
Copy link
Owner

This is no longer needed to create a new Deque instance. Instead, use one of the following:

var stringDeque deque.Deque[string]
stringDeque := new(deque.Deque[string])
stringDeque := &deque.Deque[string]{}

To set current capacity, use Grow. To set base capacity use SetBaseCap.

This is no longer needed to create a new Deque instance. Instead, use one of the following:
```
var stringDeque deque.Deque[string]
stringDeque := new(deque.Deque[string])
stringDeque := &deque.Deque[string]{}
```

To set current capacity, use `Grow`. To set base capacity use `SetBaseCap`.
@gammazero gammazero merged commit f0435ef into main Nov 15, 2024
2 checks passed
@gammazero gammazero deleted the no-new-func branch November 15, 2024 08:10
@maypok86
Copy link

@gammazero
Hi, you have broken backward compatibility with this release, since the upgrade from 0.. to 1.. takes place without adding the prefix /v{version}. I would suggest leaving the method as it is and marking it deprecated. If you really want to remove it, then release v2.

An example of similar problems in the ristretto 1.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants