Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CursorManager의 pointing 관련 이벤트 리시버 추가 #17

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

onee-only
Copy link
Member

  1. PointerSet -> PointerSetPayload로 이름 변경
  2. CursorManager의 pointing, pointing-result 리시버 구현
  3. Cursor에 new_pointer 필드 추가

pointing 이벤트 리시버에서 cursor의 뷰 바운더리를 벗어나는지 체크를 추가했습니다.
하지만 바운더리를 벗어나면 어떤 일이 일어나야하는지 의논을 하지 않았던 것 같아 일단 비워놨습니다.

#16 과 충돌이 생기면 PR 병합 후 다시 force-push 하겠습니다.

@onee-only onee-only requested a review from byundojin November 28, 2024 00:00
Copy link
Member

@byundojin byundojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dict 접근할 때 key 있나 확인 할까요?

cursor/internal/cursor.py Show resolved Hide resolved
cursor/manager/internal/cursor_manager.py Show resolved Hide resolved
@onee-only
Copy link
Member Author

dict 접근할 때 key 있나 확인 할까요?

#17 (comment) 에서 이야기한 바와 같습니다.
동적으로 dict key-value가 바뀐다면 확인이 필요하지만 정적으로 전달되는 거라면 굳이 런타임에서 체크할 필요가 없다고 생각해요.

@onee-only onee-only force-pushed the feature/cursor-manager-pointing-receiver branch from 1ce87dd to 8778688 Compare November 28, 2024 01:36
@onee-only onee-only requested a review from byundojin November 28, 2024 01:38
@byundojin
Copy link
Member

👍

@byundojin byundojin merged commit 1d0dbd4 into develop Nov 28, 2024
1 check passed
@onee-only onee-only deleted the feature/cursor-manager-pointing-receiver branch November 28, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants