Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cursor event 통합 #22

Merged
merged 5 commits into from
Nov 28, 2024
Merged

cursor event 통합 #22

merged 5 commits into from
Nov 28, 2024

Conversation

byundojin
Copy link
Member

No description provided.

@byundojin byundojin requested a review from onee-only November 28, 2024 10:36
@onee-only onee-only changed the title Feature/unite cursor event cursor event 통합 Nov 28, 2024
onee-only
onee-only reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@onee-only onee-only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한번에 수정 부탁드립니다 😉

cursor/manager/internal/cursor_manager.py Outdated Show resolved Hide resolved
board/handler/internal/board_handler.py Outdated Show resolved Hide resolved
board/handler/test/board_handler_test.py Outdated Show resolved Hide resolved
conn/manager/internal/connection_manager.py Outdated Show resolved Hide resolved
board/handler/test/board_handler_test.py Outdated Show resolved Hide resolved
cursor/manager/test/cursor_manager_test.py Outdated Show resolved Hide resolved
cursor/manager/test/cursor_manager_test.py Outdated Show resolved Hide resolved
cursor/manager/internal/cursor_manager.py Outdated Show resolved Hide resolved
cursor/manager/test/cursor_manager_test.py Outdated Show resolved Hide resolved
cursor/manager/test/cursor_manager_test.py Outdated Show resolved Hide resolved
byundojin and others added 2 commits November 28, 2024 19:50
@byundojin @onee-only
Apply suggestions from code review
079f5e9 
이름 잘못 씀

Co-authored-by: onee-only <kimww0306@gmail.com>
@byundojin
이름 잘못 씀 2
27ea6cb
onee-only
onee-only approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@onee-only onee-only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@onee-only onee-only merged commit 3c2349d into develop Nov 28, 2024
1 check passed
@onee-only onee-only deleted the feature/unite-cursor-event branch November 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onee-only onee-only onee-only approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byundojin @onee-only