Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

범위 관련 예외처리 추가 #88

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Conversation

onee-only
Copy link
Member

  • fetch-tiles, set-view-size, 커넥션 생성 시 범위 검사 추가

일단 모두 Section.LENGTH * 2 를 limit으로 하드코딩 해 놨는데 이후 환경변수로 바꿀 예정입니다.

set-view-size와 커넥션 생성을 분리하여 따로 로직을 실행 하는 것이 불필요하다고 생각합니다.
더 좋은 형태는 커넥션 생성 때는 커서를 만들어 놓기만 하고, 이후 클라이언트에서 set-view-size를 호출하여 커서를 완성하는 것인 것 같습니다.
cursor pending 처리할때 같이 작업하면 좋을 것 같습니다.

@onee-only onee-only requested a review from byundojin December 26, 2024 08:25
byundojin
byundojin previously approved these changes Dec 27, 2024
@onee-only onee-only force-pushed the feature/fetch-tiles-exceptions branch from ab3322d to 10a48f4 Compare December 27, 2024 14:15
@onee-only onee-only merged commit f7647a7 into develop Dec 27, 2024
1 check passed
@onee-only onee-only deleted the feature/fetch-tiles-exceptions branch December 27, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants