Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventRecorder 추가 #93

Merged
merged 1 commit into from
Dec 29, 2024
Merged

EventRecorder 추가 #93

merged 1 commit into from
Dec 29, 2024

Conversation

onee-only
Copy link
Member

#92 가 병합된 후 리뷰 부탁드립니다.

  • EventRecorder 클래스를 추가하여 모든 event 기록
  • 기존에 event 출력하던 _debug() 메서드 제거 -> 이제 서버 로그에 이벤트가 출력되지 않음

고려 사항:

  • multicast와 broadcast 이벤트는 어떻게 처리하는게 좋을까요? 실제 이벤트는 header에 명시되어 있어서 쿼리하기 쉽지 않을 것으로 보입니다.
  • 기록된 event를 이용해 진행상황을 다시 시뮬레이팅 하려면, random의 seed를 직접 넣어줘야 할 것입니다. (예: 커서 스폰 위치 결정)

@onee-only onee-only requested a review from byundojin December 29, 2024 00:20
byundojin
byundojin previously approved these changes Dec 29, 2024
@onee-only onee-only dismissed byundojin’s stale review December 29, 2024 13:29

The merge-base changed after approval.

@onee-only onee-only force-pushed the feature/add-event-recorder branch from 470b7f8 to 73ff96a Compare December 29, 2024 13:30
@onee-only onee-only merged commit c911e4e into develop Dec 29, 2024
1 check passed
@onee-only onee-only deleted the feature/add-event-recorder branch December 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants