[Improvement] Add graceful shutdown of services (DataLinkDC#3130)

gaoyan1998 · Mar 19, 2024 · 4518e74 · 4518e74
1 parent ba565b7
commit 4518e74
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/add-assignees.yml b/.github/workflows/add-assignees.yml
@@ -37,9 +37,9 @@ jobs:
           actions: 'create-comment'
           issue-number: ${{ github.event.issue.number }}
           body: |
-            Hello, this issue is about UDF, so I assign it to @gaoyan1998 and @zackyoungh. If you have any questions, you can comment and reply.
+            Hello @${{ github.event.issue.user.login }}, this issue is about UDF, so I assign it to @gaoyan1998 and @zackyoungh. If you have any questions, you can comment and reply.
             
-            你好, 这个 issue 是关于 UDF 的，所以我把它分配给了 @gaoyan1998 和 @zackyoungh。如有任何问题，可以评论回复。
+            你好 @${{ github.event.issue.user.login }}, 这个 issue 是关于 UDF 的，所以我把它分配给了 @gaoyan1998 和 @zackyoungh。如有任何问题，可以评论回复。
 
   assign-k8s-problem-to-developer:
     runs-on: ubuntu-latest
@@ -58,9 +58,9 @@ jobs:
           actions: 'create-comment'
           issue-number: ${{ github.event.issue.number }}
           body: |
-            Hello, this issue is about K8S, so I assign it to @gaoyan1998 and @zackyoungh. If you have any questions, you can comment and reply.
+            Hello @${{ github.event.issue.user.login }}, this issue is about K8S, so I assign it to @gaoyan1998 and @zackyoungh. If you have any questions, you can comment and reply.
             
-            你好, 这个 issue 是关于 K8S 的，所以我把它分配给了 @gaoyan1998 和 @zackyoungh。如有任何问题，可以评论回复。
+            你好 @${{ github.event.issue.user.login }}, 这个 issue 是关于 K8S 的，所以我把它分配给了 @gaoyan1998 和 @zackyoungh。如有任何问题，可以评论回复。
 
   assign-web-problem-to-developer:
     runs-on: ubuntu-latest
@@ -79,9 +79,9 @@ jobs:
           actions: 'create-comment'
           issue-number: ${{ github.event.issue.number }}
           body: |
-            Hello, this issue is about web, so I assign it to @Zzm0809. If you have any questions, you can comment and reply.
+            Hello @${{ github.event.issue.user.login }}, this issue is about web, so I assign it to @Zzm0809. If you have any questions, you can comment and reply.
             
-            你好, 这个 issue 是关于 web 的，所以我把它分配给了 @Zzm0809。如有任何问题，可以评论回复。
+            你好 @${{ github.event.issue.user.login }}, 这个 issue 是关于 web 的，所以我把它分配给了 @Zzm0809。如有任何问题，可以评论回复。
 
   assign-cdc-problem-to-developer:
     runs-on: ubuntu-latest
@@ -100,6 +100,6 @@ jobs:
           actions: 'create-comment'
           issue-number: ${{ github.event.issue.number }}
           body: |
-            Hello, this issue is about CDC/CDCSOURCE, so I assign it to @aiwenmo. If you have any questions, you can comment and reply.
+            Hello @${{ github.event.issue.user.login }}, this issue is about CDC/CDCSOURCE, so I assign it to @aiwenmo. If you have any questions, you can comment and reply.
             
-            你好, 这个 issue 是关于 CDC/CDCSOURCE 的，所以我把它分配给了 @aiwenmo。如有任何问题，可以评论回复。
+            你好 @${{ github.event.issue.user.login }}, 这个 issue 是关于 CDC/CDCSOURCE 的，所以我把它分配给了 @aiwenmo。如有任何问题，可以评论回复。
diff --git a/.github/workflows/issue-check-inactive.yml b/.github/workflows/issue-check-inactive.yml
@@ -35,9 +35,9 @@ jobs:
           inactive-day: 30
           inactive-label: 'Invalid'
           body: |
-            Hello, this issue has not been active for more than 30 days. This issue will be closed in 7 days if there is no response. If you have any questions, you can comment and reply.
+            Hello @${{ github.event.issue.user.login }}, this issue has not been active for more than 30 days. This issue will be closed in 7 days if there is no response. If you have any questions, you can comment and reply.
             
-            你好, 这个 issue 30 天内没有活跃，7 天后将关闭，如需回复，可以评论回复。
+            你好 @${{ github.event.issue.user.login }}, 这个 issue 30 天内没有活跃，7 天后将关闭，如需回复，可以评论回复。
 
       - name: Add inactive labels
         if: ${{ success() }} # 代表上边的 check-inactive 成功执行 才会执行本步骤

diff --git a/dinky-admin/src/main/resources/application.yml b/dinky-admin/src/main/resources/application.yml
@@ -4,6 +4,7 @@
 # Dinky application port
 server:
   port: 8888
+  shutdown: graceful
 
 spring:
   # Dinky application name
@@ -17,6 +18,8 @@ spring:
     # note: the h2 database is only for experience use, and the related data that has been created cannot be migrated, please use it with caution
     active: ${DB_ACTIVE:h2} #[h2,mysql,pgsql]
     include: jmx
+  lifecycle:
+    timeout-per-shutdown-phase: 30s
 
   # mvc config
   mvc: