Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for svg jupyter issue #135

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

pedritomelenas
Copy link
Contributor

Workaroung for svg displaying problems in jupyter jupyterlab/jupyterlab#10464

Workaroung for svg displaying problems in jupyter jupyterlab/jupyterlab#10464
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 26.14%. Comparing base (62de7e7) to head (4410d3e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
gap/JupyterUtil.gi 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   26.32%   26.14%   -0.19%     
==========================================
  Files          14       14              
  Lines         870      876       +6     
==========================================
  Hits          229      229              
- Misses        641      647       +6     
Files with missing lines Coverage Δ
gap/JupyterUtil.gi 9.37% <0.00%> (-0.63%) ⬇️

@pedritomelenas
Copy link
Contributor Author

Please, do not merge. If the svg is too big it will be cut.
This does not happen in vscode, but it does on any browseer.
I am trying to figure out how to bring up a scroll bar in this case.

@olexandr-konovalov olexandr-konovalov changed the title workaround for svg juupyter issue workaround for svg jupyter issue Aug 28, 2024
@pedritomelenas
Copy link
Contributor Author

now it seems to work; there was also a problem with "-o" in Linux; it works for macos

@pedritomelenas
Copy link
Contributor Author

@ManuelAFDelgado mentions that it does not work on linux; I will check that.
Please do not merge

@pedritomelenas
Copy link
Contributor Author

Did some changes. For some reason the output of Base64String was not usable under macos, and so I rely on base64 -i. @ManuelAFDelgado, please check!

@ManuelAFDelgado
Copy link

Everything works perfectly with the examples I checked. Thank you @pedritomelenas.

@olexandr-konovalov olexandr-konovalov merged commit 34b60ec into gap-packages:master Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants