Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Add downtime recording rules for moving time windows #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add downtime recording rules for moving time windows #31

wants to merge 3 commits into from

Conversation

istvanballok
Copy link
Contributor

@istvanballok istvanballok commented May 11, 2022 •
edited
Loading

What this PR does / why we need it:

Add downtime recording rules for moving time windows

@istvanballok istvanballok requested a review from a team as a code owner May 11, 2022 08:57
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 11, 2022
wyb1
wyb1 reviewed May 13, 2022
View reviewed changes
charts/connectivity-exporter/rules/error-budget.yaml
- record: downtime
labels:
kind: moving
in: four_weeks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open question is if we should do 4 weeks or 30 days for the moving window "month". 4 weeks is nice because it builds on the previous recording rule, but 30 days is usually closer to the length of a month.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I chose 4 weeks because I remember reading something about it in the SRE book. I looked it up now:

https://sre.google/workbook/implementing-slos/

We recommend defining this period as an integral number of weeks so it always contains the same number of weekends. For example, if you use a 30-day window, some periods might include four weekends while others include five weekends. If weekend traffic differs significantly from weekday traffic, your SLIs may vary for uninteresting reasons.

@istvanballok @wyb1
Add downtime recording rules for moving time windows
a5e71e0 
Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 19, 2022
istvanballok and others added 2 commits May 19, 2022 11:19
@istvanballok @wyb1
Add an uptime dashboard that supports anchored and moving intervals
200abd5 
Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
@istvanballok @wyb1
Rename recording rules to downtime
931e632 
The previous name error budget didn't capture it well that actually
the downtime of the sni-s is calculated.

Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 18, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wyb1 wyb1 wyb1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istvanballok @wyb1 @gardener-robot