Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the provider type predicates in webhooks #885

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove the provider type predicates in webhooks #885

merged 1 commit into from
Dec 6, 2024

Conversation

LucaBernstein
Copy link
Member

How to categorize this PR?

/area usability
/kind cleanup
/platform gcp

What this PR does / why we need it:
Cleanup the duplicate check for an object's provider type.

Which issue(s) this PR fixes:
Part of gardener/gardener#10745

Special notes for your reviewer:
/cc @timuthy

Release note:

Remove the duplicate provider type check from the admission webhooks.

@LucaBernstein LucaBernstein requested review from a team as code owners November 4, 2024 12:12
@gardener-robot gardener-robot added the needs/review Needs review label Nov 4, 2024
@LucaBernstein LucaBernstein mentioned this pull request Nov 4, 2024
Open
@gardener-robot gardener-robot added area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up platform/gcp Google cloud platform/infrastructure labels Nov 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 4, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Nov 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2024
hebelsan
hebelsan approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 27, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2024
@AndreasBurger AndreasBurger merged commit 2cc8351 into gardener:master Dec 6, 2024
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2024
@LucaBernstein LucaBernstein deleted the 10745-cleanup-provider-type-predicates branch December 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaBernstein @hebelsan @AndreasBurger @gardener-robot-ci-2 @gardener-robot