csi-driver-node: set GOMAXPROCS #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gardener-robot
added
area/performance
|
Thank you @Garfield96 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
@Garfield96 Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
@Garfield96 Thank you for the find. Quite interesting indeed. Small nit: I think the original upstream issue is kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#968, which may be interesting. Could please add a comment with this issue and I believe it's okay to proceed. |
|
Also based on the upstream PR, maybe the idiomatic way is to use the provided csi flag |
Garfield96
force-pushed
the
set-gomaxprocs
branch
from
6e0a2a8 to
e9622d3
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area performance
/kind enhancement
/platform gcp
What this PR does / why we need it:
Golang creates internal data structures based on the number of available CPUs. As a result, the memory consumption increases on larger machines. However, these data structures would be only needed if the load would scale with the size of the nodes. This isn't the case for CSI-drivers, since the number of volumes doesn't scale with the node size. Therefore, this change overwrites the automatically detected number of CPUs and sets it to 2 using the GOMAXPROCS environment variable. Therefore, memory consumption is stable across all node sizes. As a result, the VPA doesn't have to scale up the resources if a cluster uses many large nodes, which in the worst case could result in pod eviction.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: