Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop KonnectivityTunnel feature gate #4247

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Drop KonnectivityTunnel feature gate #4247

merged 2 commits into from
Jul 5, 2021

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area networking open-source
/kind cleanup

What this PR does / why we need it:
With #3771 and #3812, the Gardener community has agreed to pursue another VPN solution for the future and to drop KonnectivityTunnel. This PR cleans up the feature and all related code of it.

Which issue(s) this PR fixes:
Fixes #

Release note:

The `KonnectivityTunnel` feature gate in gardenlet has been dropped and removed from the code. If you upgrade to this Gardener version make sure that the feature gate is disabled and that all shoots were reconciled after you disabled it.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2021
@rfranzke rfranzke force-pushed the remove/konnectivity branch from 09dd611 to a05cf8f Compare June 23, 2021 15:09
@rfranzke rfranzke force-pushed the remove/konnectivity branch from a05cf8f to 2c33f89 Compare June 23, 2021 15:20
@rfranzke
Copy link
Member Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review June 23, 2021 15:21
@gardener-robot gardener-robot requested a review from a team as a code owner June 23, 2021 15:21
@vpnachev vpnachev mentioned this pull request Jun 23, 2021
Open
vpnachev
vpnachev previously approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

charts/images.yaml
@@ -90,10 +90,6 @@ images:
sourceRepository: github.com/gardener/vpn2
repository: eu.gcr.io/gardener-project/gardener/vpn-seed-server
tag: "0.4.0"
- name: konnectivity-server
sourceRepository: github.com/gardener/replica-reloader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened gardener-attic/replica-reloader#7 to follow up after this PR is merged.

@vpnachev
Copy link
Member

I guess it will be nice to add a short note in https://github.com/gardener/gardener/blob/master/docs/proposals/11-apiserver-network-proxy.md that it was deprecated and removed in favor of https://github.com/gardener/gardener/blob/master/docs/proposals/14-reversed-cluster-vpn.md. WDYT?

@rfranzke
Copy link
Member Author

I guess it will be nice to add a short note in https://github.com/gardener/gardener/blob/master/docs/proposals/11-apiserver-network-proxy.md that it was deprecated and removed in favor of https://github.com/gardener/gardener/blob/master/docs/proposals/14-reversed-cluster-vpn.md. WDYT?

Not sure, those are proposal documents and we usually do not keep them up-to-date (e.g., GEP-1 was not touched since initial contribution).

@vpnachev
Copy link
Member

I see status field in the GEP template https://github.com/gardener/gardener/blob/master/docs/proposals/00-template.md, we can can just add that it is deprecated and removed.

vpnachev
vpnachev previously approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@rfranzke You need rebase this pull request with latest master branch. Please check.

@rfranzke rfranzke dismissed stale reviews from vpnachev and ialidzhikov via be6a1dc July 1, 2021 12:19
@rfranzke rfranzke force-pushed the remove/konnectivity branch from 86e7aa8 to be6a1dc Compare July 1, 2021 12:19
@gardener-robot
Copy link

@DockToFuture You have pull request review open invite, please check

vpnachev
vpnachev approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit 17de192 into gardener:master Jul 5, 2021
@rfranzke rfranzke deleted the remove/konnectivity branch July 6, 2021 06:19
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@rfranzke
Drop KonnectivityTunnel feature gate (gardener#4247)
376559b 
* Drop KonnectivityTunnel feature gate

* Update GEP11 metadata
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@rfranzke
Drop KonnectivityTunnel feature gate (gardener#4247)
1b50746 
* Drop KonnectivityTunnel feature gate

* Update GEP11 metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@ScheererJ ScheererJ ScheererJ left review comments

@ialidzhikov ialidzhikov ialidzhikov left review comments

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

Assignees
No one assigned
Labels
area/networking Networking related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rfranzke @vpnachev @gardener-robot @ialidzhikov @ScheererJ @gardener-robot-ci-1 @timebertt @gardener-robot-ci-2 @gardener-robot-ci-3