Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout of edit.html as design #37 #46

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

layout of edit.html as design #37 #46

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 25, 2020

Description

Made the layout of edit.html as per the design.

Fixes # (37)

Change in layout

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested the layout on chrome://extensions/ on chrome (Load unpacked)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@garimasingh128
Copy link
Owner

garimasingh128 commented Dec 6, 2020

  • Mention and link the issues this PR solves
  • content and changes looks fine but I would advice you to double check for minor errors if any.
Conflicting files
edit.html

resolve these

@garimasingh128
Copy link
Owner

Please resolve the conflicts asap!

@garimasingh128
Copy link
Owner

Please do this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant